Skip to content

DEPR: special-casing PeriodDtype in Series.where/Series/mask fallback #45148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

DEPR: special-casing PeriodDtype in Series.where/Series/mask fallback #45148

wants to merge 6 commits into from

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel added API - Consistency Internal Consistency of API/Behavior Deprecate Functionality to remove in pandas labels Jan 7, 2022
@jreback jreback added this to the 1.4 milestone Jan 8, 2022
@jreback
Copy link
Contributor

jreback commented Jan 8, 2022 •
edited
Loading

doesn't this overlap with #45193 ? IOW we should either merge both or neither for 1.4

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jan 8, 2022 •
edited
Loading

doesn't this overlap with #45193 ? IOW we should either merge both or neither for 1.4

It does overlap, yes. My expectation is that #45193 wont make it in time for 1.4.

IOW we should either merge both or neither for 1.4

No. This should be done especially if we dont do 45193.

@jreback
Copy link
Contributor

jreback commented Jan 8, 2022

doesn't this overlap with #45193 ? IOW we should either merge both or neither for 1.4

It does overlap, yes. My expectation is that #45193 wont make it in time for 1.4.

IOW we should either merge both or neither for 1.4

No. This should be done especially if we dont do 45193.

got it

@jreback jreback modified the milestones: 1.4, 1.5 Jan 12, 2022
@jbrockmendel
Copy link
Member Author

we could plausibly call this a bugfix on the grounds that Series.mask(..., inplace=True) coerces while Series.mask(..., inplace=False) raises is inconsistent

@jreback jreback mentioned this pull request Jan 16, 2022
Closed
@jbrockmendel
Copy link
Member Author

closing in favor of #45546

@jbrockmendel jbrockmendel deleted the ref-less-special-4 branch January 22, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API - Consistency Internal Consistency of API/Behavior Deprecate Functionality to remove in pandas
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback