Skip to content

TYP: Add new variable and then convert to ndarray in timedeltas.py #45068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2021
Merged

TYP: Add new variable and then convert to ndarray in timedeltas.py #45068

merged 1 commit into from
Dec 27, 2021

Conversation

kashifkhan
Copy link
Contributor

xref #37715

Added a result_list which is then converted to ndarray for result to return.

twoertwein
twoertwein reviewed Dec 25, 2021
View reviewed changes
jbrockmendel
jbrockmendel approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbrockmendel jbrockmendel merged commit 3713e9a into pandas-dev:master Dec 27, 2021
@jbrockmendel
Copy link
Member

thanks @kashifkhan

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Dec 27, 2021
@simonjayhawkins simonjayhawkins added this to the 1.4 milestone Dec 27, 2021
@kashifkhan kashifkhan deleted the fix_typ_err_timedeltas branch December 27, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@jbrockmendel jbrockmendel jbrockmendel approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kashifkhan @jbrockmendel @twoertwein @simonjayhawkins