DEPR: Index.__getitem__[bool] GH#44051 #44973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Dec 19, 2021
jbrockmendel
commented
- closes API: Index.__getitem__(True) returns 2D ndarray #44051
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Dec 19, 2021
| @@ -670,6 +670,21 @@ def test_getitem_2d_deprecated(self, simple_index): | |||
|
|
|||
| assert isinstance(res, np.ndarray), type(res) | |||
|
|
|||
| if not isinstance(idx, RangeIndex): | |||
There was a problem hiding this comment.
what about a list of bools?
There was a problem hiding this comment.
not sure, but definitely out of scope
jreback
added
Deprecate
jreback
requested changes
Dec 19, 2021
| @@ -540,6 +540,7 @@ Other Deprecations | |||
| - Deprecated parameter ``names`` in :meth:`Index.copy` (:issue:`44916`) | |||
| - A deprecation warning is now shown for :meth:`DataFrame.to_latex` indicating the arguments signature may change and emulate more the arguments to :meth:`.Styler.to_latex` in future versions (:issue:`44411`) | |||
| - Deprecated :meth:`Categorical.replace`, use :meth:`Series.replace` instead (:issue:`44929`) | |||
| - Deprecated :meth:`Index.__getitem__` with a bool key; use ``index.values[key]`` to get the old behavior (:issue:`44051`) | |||
There was a problem hiding this comment.
do we have other deprecated indexing like this? can you co-locate (followup ok too)
There was a problem hiding this comment.
i think from a previous version, so the note will be in a different file
jreback
approved these changes
Dec 19, 2021
|
thanks the first comment pls followup when you have a chance (list of bools when indexing) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.