Skip to content

CI/TST: Use CI moto service instead of subprocess #44612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Dec 2, 2021

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Nov 25, 2021

  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them

@jreback jreback added the CI Continuous Integration label Nov 25, 2021
@mroeschke
Copy link
Member Author

@lithomas1 how feasible do you think it would be to move our Windows and MacOS builds to Github Actions given the current jobs there?

For Azure Windows, appears we can't use Linux containers
https://stackoverflow.com/a/55351920
https://stackoverflow.com/a/57751095

For Azure MacOS, appears it doesn't support containers in general
https://docs.microsoft.com/en-us/azure/devops/pipelines/process/service-containers?view=azure-devops&tabs=yaml#requirements

The goal here was to hopefully avoid flaky behavior of running a moto service in a subprocess by running it in a container instead.

@mroeschke
Copy link
Member Author

Darn. For Github Actions, it looks like service containers only work for Ubuntu runners :(

https://docs.github.com/en/actions/using-containerized-services/about-service-containers#about-service-containers

@mroeschke
Copy link
Member Author

mroeschke commented Nov 27, 2021

@jreback thoughts about only running these s3 tests only in Linux Python 38 & 39 (and the Linux db build)? Before it was running in the Windows Python 38 & 39 builds and the Linux db build

One can still run this locally on Windows or Mac with the subprocesses

@mroeschke mroeschke changed the title WIP: CI/TST: Use CI moto service instead of subprocess CI/TST: Use CI moto service instead of subprocess Nov 28, 2021
@jreback jreback added this to the 1.4 milestone Nov 28, 2021
@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

@jreback thoughts about only running these s3 tests only in Linux Python 38 & 39 (and the Linux db build)? Before it was running in the Windows Python 38 & 39 builds and the Linux db build

One can still run this locally on Windows or Mac with the subprocesses

sounds ok to me

@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

ping when ready here

@mroeschke
Copy link
Member Author

Ready and all green here.

@jreback
Copy link
Contributor

jreback commented Nov 29, 2021

@lithomas1 if any comments

@jreback
Copy link
Contributor

jreback commented Dec 1, 2021

can you merge master

@jreback jreback merged commit 12afff1 into pandas-dev:master Dec 2, 2021
@jreback
Copy link
Contributor

jreback commented Dec 2, 2021

thanks @mroeschke

@mroeschke mroeschke deleted the ci/service/moto branch December 2, 2021 04:45
@simonjayhawkins
Copy link
Member

18 failed tests when running tests locally on ubuntu with aiohttp.client_exceptions.ClientConnectorError: Cannot connect to host localhost:5000 ssl:default [Connect call failed ('127.0.0.1', 5000)]

Is there something that needs to now be changed in the local dev setup also or should these tests be skipped locally?

@simonjayhawkins
Copy link
Member

on WSL 44 failed.

@mroeschke mroeschke mentioned this pull request Dec 2, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants