-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
CI/TST: Use CI moto service instead of subprocess #44612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@lithomas1 how feasible do you think it would be to move our Windows and MacOS builds to Github Actions given the current jobs there? For Azure Windows, appears we can't use Linux containers For Azure MacOS, appears it doesn't support containers in general The goal here was to hopefully avoid flaky behavior of running a moto service in a subprocess by running it in a container instead. |
Darn. For Github Actions, it looks like service containers only work for Ubuntu runners :( |
@jreback thoughts about only running these s3 tests only in Linux Python 38 & 39 (and the Linux db build)? Before it was running in the Windows Python 38 & 39 builds and the Linux db build One can still run this locally on Windows or Mac with the subprocesses |
sounds ok to me |
ping when ready here |
Ready and all green here. |
@lithomas1 if any comments |
can you merge master |
thanks @mroeschke |
18 failed tests when running tests locally on ubuntu with Is there something that needs to now be changed in the local dev setup also or should these tests be skipped locally? |
on WSL 44 failed. |
Uh oh!
There was an error while loading. Please reload this page.