Skip to content

TYP: changed variable new_pd_index to final_pd_index #44500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2021
Merged

TYP: changed variable new_pd_index to final_pd_index #44500

merged 3 commits into from
Nov 28, 2021

Conversation

prithvijitguha
Copy link
Contributor

xref #37715

Changed variable new_pd_index to final_pd_index in line 2099

Handled mypy type ignore[assignment] error in pandas/io/pytables.py in line 2099

@pep8speaks
Copy link

pep8speaks commented Nov 17, 2021 •
edited
Loading

Hello @prithvijitguha! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-17 15:43:05 UTC

MarcoGorelli
MarcoGorelli reviewed Nov 17, 2021
View reviewed changes
pandas/io/pytables.py Outdated
Comment on lines 2097 to 2098
# error: Incompatible types in assignment (expression has type
# "Union[ndarray, DatetimeIndex]", variable has type "Index")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thakns @prithvijitguha - this comment can be removed as well, right?

Copy link
Contributor Author

@prithvijitguha prithvijitguha Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. its from the previous "#type ignore". Do I need to fix that and commit it? Thanks for reviewing @MarcoGorelli

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarcoGorelli Thank you, just removed the comment and removed any remaining trailing whitespace. Should pass now!

@MarcoGorelli MarcoGorelli added the Typing type annotations, mypy/pyright type checking label Nov 17, 2021
@MarcoGorelli MarcoGorelli added this to the 1.4 milestone Nov 17, 2021
@prithvijitguha
Copy link
Contributor Author

Hi @MarcoGorelli Thanks for the review. Its failing one test which is similar to the test failed in another similar pull request #44231
As per this comment, #44373 (comment) its related to pyarrow.
What do you suggest? 🤔

@MarcoGorelli
Copy link
Member

It's unrelated, don't worry about it

This looks good to me, I'm just not sure about the final_pd_index variable name, so leaving this open in case others have comments

@jreback jreback merged commit 040f236 into pandas-dev:master Nov 28, 2021
@jreback
Copy link
Contributor

jreback commented Nov 28, 2021

thanks @prithvijitguha

@prithvijitguha prithvijitguha deleted the prithvi_type_fixes branch December 6, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@prithvijitguha @pep8speaks @MarcoGorelli @jreback