Skip to content

TST: fix FIXMEs #44151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2021
Merged

TST: fix FIXMEs #44151

merged 4 commits into from
Oct 24, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@alimcmaster1 alimcmaster1 added Testing pandas testing functions or related to the test suite Clean labels Oct 22, 2021
alimcmaster1
alimcmaster1 approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@alimcmaster1 alimcmaster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up! LGTM

@mroeschke mroeschke added this to the 1.4 milestone Oct 23, 2021
@jreback jreback merged commit 514852c into pandas-dev:master Oct 24, 2021
@jbrockmendel jbrockmendel deleted the fixmes branch October 24, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alimcmaster1 alimcmaster1 alimcmaster1 approved these changes

Assignees
No one assigned
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @alimcmaster1 @jreback @mroeschke