CLN: unify some fused types #43824
Merged
CLN: unify some fused types #43824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Internals
mzeitlin11
commented
Sep 30, 2021
| @@ -20,15 +20,14 @@ from numpy cimport ( | |||
| cnp.import_array() | |||
|
|
|||
|
|
|||
| cdef extern from "src/headers/cmath" namespace "std": | |||
| cdef extern from "../src/headers/cmath" namespace "std": | |||
There was a problem hiding this comment.
Without this added ../, these changes made the build fail for me locally due to not being able to find this file. Not sure why importing from dtypes instead of util would cause this to happen, but importing from ../ is now consistent with the import on L33
jreback
requested changes
Sep 30, 2021
jreback
approved these changes
Oct 1, 2021
|
@jbrockmendel if comments. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary:
numeric->numeric_tasof_tnumeric+object->numeric_object_talgos_t,join_t,reshape_ti64 + u64 + f32 + f64->iu_64_floating_t(don't love this name, suggestions welcome)groupby_tiu_64_floating_t+object->iu_64_floating_obj_trank_t(which was renamed tonumeric_object_tin CLN: share rank_t fused type #43789, so it replacesnumeric_object_tin this pr)