BUG: pandas.to_datetime raises exception when more than 50 values needs coercion to NaT (#43732) #43791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you write a test |
|
Constructing an Index from a value that will resolve to NaT causes an error, but I'm not sure if this is by design. import datetime
import pytz
import pandas as pd
# t is a date after 2262 that should be coerced into NaT
t = datetime.datetime(3000, 1, 1, 0, 0, 0, 0, pytz.UTC)
print(pd.Index([t], tz="utc")) # pandas._libs.tslibs.np_datetime.OutOfBoundsDatetime: Out of bounds nanosecond timestamp: 3000-01-01 00:00:00 |
this is expected, it is an out of bounds date. |
thomasqueirozb
force-pushed
the
issue_43732
branch
from
00104ab to
ce90ec9
Compare
|
@jbrockmendel we wrote some tests, is there anything else we need to do? |
jreback
requested changes
Oct 16, 2021
jreback
requested changes
Oct 19, 2021
thomasqueirozb
force-pushed
the
issue_43732
branch
2 times, most recently
from
1bab61c to
b257ccf
Compare
thomasqueirozb
force-pushed
the
issue_43732
branch
from
b257ccf to
003c098
Compare
jreback
requested changes
Nov 12, 2021
…ds coercion to NaT (pandas-dev#43732) Raise proper error from objects_to_datetime64ns Check for OutOfBoundsDatetime in _maybe_cache Co-authored-by: André Elimelek de Weber (andrekwr) <[email protected]> Co-authored-by: Henry Rocha (HenryRocha) <[email protected]>
Co-authored-by: André Elimelek de Weber (andrekwr) <[email protected]> Co-authored-by: Henry Rocha (HenryRocha) <[email protected]>
thomasqueirozb
force-pushed
the
issue_43732
branch
from
003c098 to
73f1633
Compare
|
pls merge master, but tests seem to be failing |
1 similar comment
|
pls merge master, but tests seem to be failing |
|
is worthwhile but needs to be passing (and pls merge master) |
|
would welcome this change but its stale. pls ping if you want to continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas.to_datetimeraises exception when more than 50 values needs coercion to NaT #43732