CI: mark user-agent tests as network #43542
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Testing
|
Hmm, actually these tests don't touch network (only use localhost) and timeout still happened, so must not be the cause |
|
Good thought! Are you confident that the timeout(s?) are from these tests? |
Now I am confident they are not from the user-agent tests since this pr skipped them, but a timeout still occurred :) But seems likely the issue is somewhere in tests/io based on the timeouts moving to windows2 after the new split. Hoping #43545 helps |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jbrockmendel, inspired by #43517 (comment). This being the source of the timeout is also supported by starting to see timeouts on windows2 after changing the split such that the io tests were included in windows2.