REGR: Resampler.aggregate fails when used with column selection #43410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oupby_agg_regr � Conflicts: � doc/source/whatsnew/v1.3.3.rst
rhshadrach
added
Bug
Regression
| # GH 42905 | ||
| ts = Timestamp("2021-02-28 00:00:00") | ||
| df = DataFrame({"class": ["beta"], "value": [69], "date": [ts]}) | ||
| result = ( |
There was a problem hiding this comment.
nit. can you make the result assignment just the op under test.
| .resample("M")["value"] | ||
| .agg(["sum", "size"]) | ||
| ) | ||
| index = pd.MultiIndex.from_tuples([("beta", ts)], names=["class", "date"]) |
There was a problem hiding this comment.
another nit. index -> expected_index or even okay to inline with the df creation as black generally tends to do a good job of making things readable
|
Thanks @simonjayhawkins - comments addressed. |
jreback
requested changes
Sep 6, 2021
jreback
approved these changes
Sep 6, 2021
|
thanks @rhshadrach |
|
@meeseeksdev backport 1.3.x |
This comment has been minimized.
This comment has been minimized.
|
@rhshadrach can you put up the manual backport :-< |
This comment has been minimized.
This comment has been minimized.
feefladder
pushed a commit
to feefladder/pandas
that referenced
this pull request
Sep 7, 2021
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 7, 2021
…ed with column selection
jreback
pushed a commit
that referenced
this pull request
Sep 7, 2021
…lumn selection (#43444) Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aggon a resampled SeriesGroupBy #42905The method
resample._GroupByMixin._gotitemcallsThe selection (which ends up in kwargs in
__init__) was being ignored.