Skip to content

CLN: make some private Index methods keyword-only #42361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pandas/core/generic.py
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ def rename(
]
raise KeyError(f"{missing_labels} not found in axis")

new_index = ax._transform_index(f, level)
new_index = ax._transform_index(f, level=level)
result._set_axis_nocheck(new_index, axis=axis_no, inplace=True)
result._clear_item_cache()

Expand Down
2 changes: 1 addition & 1 deletion pandas/core/groupby/grouper.py
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ def __init__(
self.grouping_vector, # Index
self._codes,
self._group_index,
) = index._get_grouper_for_level(mapper, ilevel)
) = index._get_grouper_for_level(mapper, level=ilevel)

# a passed Grouper like, directly get the grouper in the same way
# as single grouper groupby, use the group_info to get codes
Expand Down
9 changes: 5 additions & 4 deletions pandas/core/indexes/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -1500,7 +1500,7 @@ def _validate_names(
def _get_names(self) -> FrozenList:
return FrozenList((self.name,))

def _set_names(self, values, level=None) -> None:
def _set_names(self, values, *, level=None) -> None:
"""
Set new names on index. Each name has to be a hashable type.

Expand Down Expand Up @@ -1906,7 +1906,7 @@ def _drop_level_numbers(self, levnums: list[int]):
verify_integrity=False,
)

def _get_grouper_for_level(self, mapper, level=None):
def _get_grouper_for_level(self, mapper, *, level=None):
"""
Get index grouper corresponding to an index level

Expand All @@ -1915,7 +1915,7 @@ def _get_grouper_for_level(self, mapper, level=None):
mapper: Group mapping function or None
Function mapping index values to groups
level : int or None
Index level
Index level, positional

Returns
-------
Expand Down Expand Up @@ -5642,7 +5642,7 @@ def map(self, mapper, na_action=None):

# TODO: De-duplicate with map, xref GH#32349
@final
def _transform_index(self, func, level=None) -> Index:
def _transform_index(self, func, *, level=None) -> Index:
"""
Apply function to all values found in index.

Expand All @@ -5651,6 +5651,7 @@ def _transform_index(self, func, level=None) -> Index:
"""
if isinstance(self, ABCMultiIndex):
if level is not None:
# Caller is responsible for ensuring level is positional.
items = [
tuple(func(y) if i == level else y for i, y in enumerate(x))
for x in self
Expand Down
6 changes: 4 additions & 2 deletions pandas/core/indexes/multi.py
Original file line number Diff line number Diff line change
Expand Up @@ -761,6 +761,7 @@ def levels(self) -> FrozenList:
def _set_levels(
self,
levels,
*,
level=None,
copy: bool = False,
validate: bool = True,
Expand Down Expand Up @@ -954,6 +955,7 @@ def codes(self):
def _set_codes(
self,
codes,
*,
level=None,
copy: bool = False,
validate: bool = True,
Expand Down Expand Up @@ -1392,7 +1394,7 @@ def format(
def _get_names(self) -> FrozenList:
return FrozenList(self._names)

def _set_names(self, names, level=None, validate: bool = True):
def _set_names(self, names, *, level=None, validate: bool = True):
"""
Set new names on index. Each name has to be a hashable type.

Expand Down Expand Up @@ -1473,7 +1475,7 @@ def _set_names(self, names, level=None, validate: bool = True):
# --------------------------------------------------------------------

@doc(Index._get_grouper_for_level)
def _get_grouper_for_level(self, mapper, level):
def _get_grouper_for_level(self, mapper, *, level):
indexer = self.codes[level]
level_index = self.levels[level]

Expand Down