REF: split out sorted_rank algo #41910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No behavior change here, but two main advantages can follow this refactor:
rank_2d
does the ranking portion of the algo with different logic.rank_2d
can instead call this function, which will allow removing lots ofrank_2d
code and make keeping behaviors in sync easier.rank_2d
also does not usenogil
, which this would fix.nancorr_spearman
can use this for a simplified (and hopefully faster) reranking handling when nulls are present.The diff looks more complicated than it is because the structure was changed from
to
Benchmarks look unaffected: