Skip to content

TYP: SelectionMixin #41384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 10, 2021
Merged

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@simonjayhawkins thoughts on the FrameOrSeries vs FrameOrSeriesUnion that ive ignored here?

@simonjayhawkins
Copy link
Member

@jbrockmendel i've pushed a commit removing the ignores. feel free to revert and do that as a follow-up.

@jbrockmendel
Copy link
Member Author

Neat thanks

@jbrockmendel jbrockmendel added the Typing type annotations, mypy/pyright type checking label May 9, 2021
@simonjayhawkins simonjayhawkins added this to the 1.3 milestone May 9, 2021
@jreback jreback merged commit f570ba2 into pandas-dev:master May 10, 2021
@jreback
Copy link
Contributor

jreback commented May 10, 2021

yeah thanks @jbrockmendel and @simonjayhawkins this is like magic.

@jbrockmendel jbrockmendel deleted the typ-selection_mixin branch May 11, 2021 00:13
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants