Skip to content

REF: NDFrame dont mixin SelectionMixin #40857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2021
Merged

REF: NDFrame dont mixin SelectionMixin #40857

merged 2 commits into from
Apr 10, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jreback jreback added the Refactor Internal refactoring of code label Apr 9, 2021
@jreback jreback added this to the 1.3 milestone Apr 9, 2021
jreback
jreback approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on greenish

@jbrockmendel
Copy link
Member Author

Ping

@jreback jreback merged commit 33fec60 into pandas-dev:master Apr 10, 2021
@jbrockmendel jbrockmendel deleted the selection branch April 10, 2021 01:31
sthagen added a commit to sthagen/pandas-dev-pandas that referenced this pull request Apr 10, 2021
@sthagen
Merge pull request #172 from pandas-dev/master
76835fb 
REF: NDFrame dont mixin SelectionMixin (pandas-dev#40857)
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
REF: NDFrame dont mixin SelectionMixin (pandas-dev#40857)
13ee051
@Cedric-Magnan Cedric-Magnan mentioned this pull request Aug 9, 2021
Merged
HyukjinKwon pushed a commit to databricks/koalas that referenced this pull request Aug 26, 2021
@Cedric-Magnan
[FIX] _builtin_table import in groupby apply (changed in pandas>=1.3.…
e971d6f 
…0) (#2184)

I have recently had an issue while upgrading pandas to the latest version in my Databricks environment :

`AttributeError: type object 'SelectionMixin' has no attribute '_builtin_table'`


Pandas has recently refactored the way we import the _builtin_table and is now part of the `pandas.core.common` module instead of being an attribute of the `pandas.core.base.SelectionMixin` class.

PR that was merged in the 1.3.0 : pandas-dev/pandas#40857

This suggestion should solve the issue !
rising-star92 added a commit to rising-star92/databricks-koalas that referenced this pull request Jan 27, 2023
@rising-star92
[FIX] _builtin_table import in groupby apply (changed in pandas>=1.3.…
23365e9 
…0) (#2184)

I have recently had an issue while upgrading pandas to the latest version in my Databricks environment :

`AttributeError: type object 'SelectionMixin' has no attribute '_builtin_table'`


Pandas has recently refactored the way we import the _builtin_table and is now part of the `pandas.core.common` module instead of being an attribute of the `pandas.core.base.SelectionMixin` class.

PR that was merged in the 1.3.0 : pandas-dev/pandas#40857

This suggestion should solve the issue !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Refactor Internal refactoring of code
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @jreback