Use tempfile for creating a file in home directory for a IO test #40122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrispe
commented
Feb 28, 2021
chrispe
commented
- closes BUG: IO unit test creates file at home directory #40091
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Feb 28, 2021
pandas/tests/io/test_common.py
Outdated
| with icom.get_handle(filename, "w") as handles: | ||
| assert os.path.isabs(handles.handle.name) | ||
| assert os.path.expanduser(filename) == handles.handle.name | ||
| with tempfile.NamedTemporaryFile(dir=os.path.expanduser("~/")) as tmp: |
There was a problem hiding this comment.
I agree, but current implementation of tm.ensure_clean doesn't support custom directories (which is needed in this test case). Should we then first extend that function?
There was a problem hiding this comment.
ok i guess this is fine. can you use pathlib.Path instead
lithomas1
added
the
Testing
jreback
requested changes
Mar 1, 2021
pandas/tests/io/test_common.py
Outdated
| with icom.get_handle(filename, "w") as handles: | ||
| assert os.path.isabs(handles.handle.name) | ||
| assert os.path.expanduser(filename) == handles.handle.name | ||
| with tempfile.NamedTemporaryFile(dir=os.path.expanduser("~/")) as tmp: |
There was a problem hiding this comment.
ok i guess this is fine. can you use pathlib.Path instead
Since we want to test for hardcoded case of "~", we should not use the Path.home()
jreback
approved these changes
Mar 1, 2021
|
lgtm ping on greenish (there is a failing numpy_dev build ATM) |
|
thanks @chrispe very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.