Skip to content

Updated Comparison to Excel documentation with code example of read_excel and to_excel for #38990 #39242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 21, 2021
Merged

Updated Comparison to Excel documentation with code example of read_excel and to_excel for #38990 #39242

merged 3 commits into from
Jan 21, 2021

Conversation

bsun94
Copy link
Contributor

@bsun94 bsun94 commented Jan 17, 2021 •
edited
Loading

  • This is my first time contributing - please let me know if any other detail is needed! Essentially I just swapped the order of the "Excel" and "CSV" paragraphs in the data importing section, so that the examples given for to_excel and read_excel would flow from the CSV example without needing repeated code/codeblocks.

@bsun94 bsun94 mentioned this pull request Jan 17, 2021
Closed
17 tasks
afeld
afeld approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@afeld afeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one note. Otherwise, 👍 from me. Nice work!

@afeld
Copy link
Member

afeld commented Jan 21, 2021

Oh, sorry, one other thing: for future commits, make sure to use these prefixes. I think that can be fixed by whomever merges doing a squash, so don't worry about changing it (unless you want to — instructions).

@jreback jreback added Docs IO Excel read_excel, to_excel labels Jan 21, 2021
@jreback jreback added this to the 1.3 milestone Jan 21, 2021
@bsun94
Copy link
Contributor Author

bsun94 commented Jan 21, 2021

Thank you Aidan, Jeff - and thank you Aidan for guiding me on my first ever pandas PR! hopefully more to come!

@jreback jreback merged commit 375a3c8 into pandas-dev:master Jan 21, 2021
@jreback
Copy link
Contributor

jreback commented Jan 21, 2021

thanks @bsun94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@afeld afeld afeld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Docs IO Excel read_excel, to_excel
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@bsun94 @afeld @jreback