Skip to content

TST: Fix missing import in io/tests/test_json #3855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2013

Conversation

jtratner
Copy link
Contributor

Nose import is missing. If you get to the error at the last line, it throws an error because nose is never imported.

@jreback
Copy link
Contributor

jreback commented Jun 11, 2013

were line endings screwed up?

@jtratner
Copy link
Contributor Author

no, I mean that it raises nose.skipTest but never has import nose. Just ran the test and it failed that way, which is how I noticed it.

@jtratner
Copy link
Contributor Author

however, it looks like github screwed up the commit

@jtratner
Copy link
Contributor Author

so I'll redo it on my computer :-/

@jreback
Copy link
Contributor

jreback commented Jun 11, 2013

hmm I ran these using nosetests directly so maybe that's why didn't have a problem

@jtratner
Copy link
Contributor Author

You have to get a urllib2.UrlError to see it...

Nose import is missing. If you get to the error at the last line (under
urllib), python complains because nose is never imported.
@jtratner
Copy link
Contributor Author

Much better now...as you can see, it's a oneline change.

@hayd
Copy link
Contributor

hayd commented Jun 12, 2013

yesterday: https://dev.twitter.com/blog/api-v1-is-retired lol

jreback added a commit that referenced this pull request Jun 12, 2013
TST: Fix missing import in io/tests/test_json
@jreback jreback merged commit 7a0adba into pandas-dev:master Jun 12, 2013
@jtratner jtratner deleted the patch-1 branch June 12, 2013 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants