TST: Fix missing import in io/tests/test_json #3855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
were line endings screwed up? |
|
no, I mean that it raises |
|
however, it looks like github screwed up the commit |
|
so I'll redo it on my computer :-/ |
|
hmm I ran these using nosetests directly so maybe that's why didn't have a problem |
|
You have to get a urllib2.UrlError to see it... |
Nose import is missing. If you get to the error at the last line (under urllib), python complains because nose is never imported.
|
Much better now...as you can see, it's a oneline change. |
|
yesterday: https://dev.twitter.com/blog/api-v1-is-retired lol |
jreback
added a commit
that referenced
this pull request
Jun 12, 2013
TST: Fix missing import in io/tests/test_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nose import is missing. If you get to the error at the last line, it throws an error because nose is never imported.