Skip to content

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

xref #38279 (comment) cc @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche added this to the 1.2 milestone Dec 7, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@jorisvandenbossche jorisvandenbossche added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Performance Memory or execution speed performance labels Dec 7, 2020
@jreback
Copy link
Contributor

jreback commented Dec 7, 2020

lgtm. do we have / need asv's? do we need a whatsnew note (not sure if this was working in 1.1 at all)

@jorisvandenbossche
Copy link
Member

No, this was catched by an asv we already have, and only a regression on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Performance Memory or execution speed performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants