Skip to content

rewrite dict as literal in tests/io/parser/test_index_col.py #38336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

rewrite dict as literal in tests/io/parser/test_index_col.py #38336

wants to merge 2 commits into from

Conversation

pillemer
Copy link

@pillemer pillemer commented Dec 6, 2020

for issue # 38138
rewrite unnecessary dict call as a literal in pandas/tests/io/parser/test_index_col.py

Please let me know if anything needs to be amended, changed or fixed. I'm new to contributing.

for issue # 38138 
rewrite unnecessary dict call as a literal in pandas/tests/io/parser/test_index_col.py

Please let me know if anything needs to be amended, changed or fixed. I'm new to contributing.
@pep8speaks
Copy link

pep8speaks commented Dec 6, 2020

Hello @pillemer! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-07 04:33:22 UTC

@mroeschke
Copy link
Member

Thanks. Could you fix up the linting errors?

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Dec 6, 2020
fixed linting error
@pillemer
Copy link
Author

pillemer commented Dec 7, 2020

@mroeschke, no problem, done! Is there anything else?

@MarcoGorelli
Copy link
Member

@mroeschke, no problem, done! Is there anything else?

There's still some failures, could you try again please?

pre-commit run --files pandas/tests/io/parser/test_index_col.py

@MarcoGorelli
Copy link
Member

closing as it looks like this one's already been done, sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants