Skip to content

pandas/core/strings/accesory.py Unnecessary dict call - rewrite as a literal #38138 #38280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 4, 2020

Conversation

UrielMaD
Copy link
Contributor

@UrielMaD UrielMaD commented Dec 4, 2020

xref #38138

File modified: pandas/core/strings/accesory.py

Changed unnecessary dict calls for flake8 (C408) standard:

  • Rewrite dict() as {}

  • closes #xxxx

  • tests added / passed

  • passes black pandas

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

  • whatsnew entry

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 4, 2020
@jreback jreback added this to the 1.2 milestone Dec 4, 2020
@jreback jreback merged commit d2b7aa1 into pandas-dev:master Dec 4, 2020
@jreback
Copy link
Contributor

jreback commented Dec 4, 2020

thanks @UrielMaD

@UrielMaD UrielMaD deleted the fix-dict-call branch December 4, 2020 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants