Skip to content

Added docs to fix GL08 errors in CustomBusinessHours #37846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mohdkashif93
Copy link
Contributor

@mohdkashif93 mohdkashif93 commented Nov 14, 2020

Currently even after adding the docstrings the command python scripts/validate_docstrings.py --errors=GL08 does not pick up the changes.

@jreback jreback added this to the 1.2 milestone Nov 15, 2020
@jreback
Copy link
Contributor

jreback commented Nov 15, 2020

Currently even after adding the docstrings the command python scripts/validate_docstrings.py --errors=GL08 does not pick up the changes.

not sure we are checking this yet (idea is to fix the errors then add the check). dependens on how much fails across the codebase.

@MarcoGorelli
Copy link
Member

not sure we are checking this yet (idea is to fix the errors then add the check). dependens on how much fails across the codebase.

There are still lots of GL08 errors in many files, so adding this error to the check would require lots more docstrings.

Though this

Currently even after adding the docstrings the command python scripts/validate_docstrings.py --errors=GL08 does not pick up the changes.

may require further investigation, not sure why it wouldn't pick up the changes (this happened even after running python setup.py build_ext -i -j 4)

@jreback jreback merged commit b6f6957 into pandas-dev:master Nov 17, 2020
@jreback
Copy link
Contributor

jreback commented Nov 17, 2020

thanks @mohdkashif93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants