DOC: Add caveat to to_stata with version=119 #37700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
reviewed
Nov 8, 2020
| @@ -2129,7 +2129,7 @@ def to_stata( | |||
| characters or fewer while versions 117 and later allow strings | |||
| with lengths up to 2,000,000 characters. Versions 118 and 119 | |||
| support Unicode characters, and version 119 supports more than | |||
| 32,767 variables. | |||
There was a problem hiding this comment.
I wouldn't say "for now". Something along the lines of
"Version 119 should usually only be used when the number of variables exceeds the capacity of dta format 118. Exporting smaller datasets in format 119 may have unintended consequences, and, as of November 2020, Stata SE cannot read version 119 files. "
There was a problem hiding this comment.
Thanks,
I copied your suggestion verbatim.
hongshaoyang
force-pushed
the
37490-docstata
branch
from
ff822bd to
59fef28
Compare
|
LGTM. |
|
thanks @hongshaoyang |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff