-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Regression in offsets caused offsets to be no longer hashable #37288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
f3dece0
Add hash function to Tick class for offsets
phofl fdd983c
Add tests and whatsnew
phofl a7611de
Fix whatsnew
phofl 9bac84c
Add offsets function and hash function
phofl e5b66a0
Adress review comments
phofl 10b8a17
Merge branch 'master' of https://github.com/pandas-dev/pandas into 37267
phofl f2e8835
Update pandas/_libs/tslibs/offsets.pyx
phofl 0f70590
Add empty line
phofl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -752,6 +752,9 @@ cdef class Tick(SingleConstructorOffset): | |
"Tick offset with `normalize=True` are not allowed." | ||
) | ||
|
||
def __hash__(self) -> int: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @jbrockmendel ok here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, LGTM
phofl marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return hash(self._params) | ||
|
||
# FIXME: Without making this cpdef, we get AttributeError when calling | ||
# from __mul__ | ||
cpdef Tick _next_higher_resolution(Tick self): | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.