Skip to content

TST: RollingGroupby(..., center=True, on=...) #37154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

mroeschke
Copy link
Member

Didn't look like we had a test case that exactly covered this.

@mroeschke mroeschke force-pushed the test/groupby_rolling_center_on branch from c213bb0 to 47828c5 Compare October 16, 2020 04:10
@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding labels Oct 16, 2020
@mroeschke mroeschke added this to the 1.2 milestone Oct 16, 2020
@jreback jreback merged commit 53b58e8 into pandas-dev:master Oct 16, 2020
@mroeschke mroeschke deleted the test/groupby_rolling_center_on branch October 16, 2020 16:16
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Window rolling, ewma, expanding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: groupby.rolling.mean seems to roll over different groups when center=True
2 participants