CLN: pandas/core/indexing.py #36713
Merged
CLN: pandas/core/indexing.py #36713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Sep 28, 2020
pandas/core/indexing.py
Outdated
| @@ -834,11 +831,9 @@ def _getitem_nested_tuple(self, tup: Tuple): | |||
| if self.name != "loc": | |||
| # This should never be reached, but lets be explicit about it | |||
| raise ValueError("Too many indices") | |||
| try: | |||
| with suppress(IndexingError): | |||
| result = self._handle_lowerdim_multi_index_axis0(tup) | |||
| return result | |||
There was a problem hiding this comment.
You could avoid the declaration of result here.
pandas/core/indexing.py
Outdated
| @@ -782,14 +782,11 @@ def _getitem_lowerdim(self, tup: Tuple): | |||
| # ...but iloc should handle the tuple as simple integer-location | |||
| # instead of checking it as multiindex representation (GH 13797) | |||
| if isinstance(ax0, ABCMultiIndex) and self.name != "iloc": | |||
| try: | |||
| with suppress(IndexingError): | |||
| result = self._handle_lowerdim_multi_index_axis0(tup) | |||
| return result | |||
|
LGTM pending green. If you're looking for high-value things to do in this file, narrowing what we're catching/suppressing is a never-ending battle. |
|
Lgtm |
|
Can anyone re-start CI? Looks like there were internal CI engine failures. |
jreback
added
Indexing
|
thanks @ivanovmg nice cleanup |
kesmit13
pushed a commit
to kesmit13/pandas
that referenced
this pull request
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffSlight clean-up of
pandas/core/indexing.py.suppressinstead oftry/except/pass(starting from Python 3.7)_validate_key_length