REF: share insert between DTI/TDI/PI #36439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanovmg
reviewed
Sep 18, 2020
| new_i8s = np.concatenate([self[:loc].asi8, [item], self[loc:].asi8]) | ||
| arr = type(self._data)._simple_new(new_i8s, dtype=self.dtype, freq=freq) | ||
| return type(self)._simple_new(arr, name=self.name) | ||
| return DatetimeIndexOpsMixin.insert(self, loc, item) |
There was a problem hiding this comment.
Would super().insert(loc, item) be better, more independent on the class name? Here and inPeriodIndex.
There was a problem hiding this comment.
super() is non-idiomatic here because of the somewhat complex inheitance chain we have; meaning you have to really undertand the mro as a reader; this is simpler. We don't actualy use super() except in a few small cases (maybe should change those).
jreback
approved these changes
Sep 18, 2020
| new_i8s = np.concatenate([self[:loc].asi8, [item], self[loc:].asi8]) | ||
| arr = type(self._data)._simple_new(new_i8s, dtype=self.dtype, freq=freq) | ||
| return type(self)._simple_new(arr, name=self.name) | ||
| return DatetimeIndexOpsMixin.insert(self, loc, item) |
There was a problem hiding this comment.
super() is non-idiomatic here because of the somewhat complex inheitance chain we have; meaning you have to really undertand the mro as a reader; this is simpler. We don't actualy use super() except in a few small cases (maybe should change those).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.