Skip to content

STY: De-privatize imported names #36235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Conversation

jbrockmendel
Copy link
Member

Getting close to the end on these.

@jreback jreback added the Code Style Code style, linting, code_checks label Sep 9, 2020
@jreback jreback added this to the 1.2 milestone Sep 9, 2020
@@ -1921,7 +1921,7 @@ def test_invalid_parser():
}


@pytest.mark.parametrize("engine", _engines)
@pytest.mark.parametrize("engine", ENGINES)
@pytest.mark.parametrize("parser", _parsers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be PARSERS

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case _parsers is a defined a few lines up

@jreback
Copy link
Contributor

jreback commented Sep 9, 2020

failing linting somewhere

@jbrockmendel
Copy link
Member Author

its the _np_version_under_118 thing again, just pushed the fix here too

@jreback jreback merged commit b5a5268 into pandas-dev:master Sep 9, 2020
@jbrockmendel jbrockmendel deleted the sty-private-5 branch September 9, 2020 01:58
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants