-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG GH31355 fixed by adding more relevant error message #36169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Tom Augspurger <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
…r intended (pandas-dev#35500) Co-authored-by: Kevin Sheppard <[email protected]>
…andas-dev#35501) Co-authored-by: Fangchen Li <[email protected]>
…R only) (pandas-dev#35535) Co-authored-by: Simon Hawkins <[email protected]>
…andas-dev#35536) Co-authored-by: Simon Hawkins <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
…v#35539) Co-authored-by: Terji Petersen <[email protected]>
…andas-dev#35540) Co-authored-by: Daniel Saxton <[email protected]>
pandas-dev#35591) Co-authored-by: Matthew Roeschke <[email protected]>
…kle (pandas-dev#35593) Co-authored-by: Tom Augspurger <[email protected]>
…n DataFrame construction (pandas-dev#35597) Co-authored-by: jbrockmendel <[email protected]>
…ndas-dev#35600) Co-authored-by: gabicca <[email protected]>
… with null values (pandas-dev#35602) Co-authored-by: Eric Goddard <[email protected]>
…blocks (pandas-dev#35601) Co-authored-by: jbrockmendel <[email protected]>
…fault with center=True (pandas-dev#35610) Co-authored-by: Matthew Roeschke <[email protected]>
…ank style is ignored on False (pandas-dev#35619) Co-authored-by: attack68 <[email protected]>
…aFrame to numpy str (pandas-dev#35617) Co-authored-by: Daniel Saxton <[email protected]>
…est DeprecationWarning (pandas-dev#35623) Co-authored-by: Simon Hawkins <[email protected]>
…umn selection no longer raises ValueError (pandas-dev#35651) Co-authored-by: Matthew Roeschke <[email protected]>
…True for non-numeric dtypes pandas-dev#3… (pandas-dev#35652) Co-authored-by: Isaac Virshup <[email protected]>
… row in-place (pandas-dev#35666) Co-authored-by: jbrockmendel <[email protected]>
…upby.rolling (pandas-dev#35699) Co-authored-by: Matthew Roeschke <[email protected]>
…rance error (pandas-dev#35702) Co-authored-by: Yutaro Ikeda <[email protected]>
…DataFrame with MI and datatime level (pandas-dev#35716) Co-authored-by: Simon Hawkins <[email protected]>
… data (pandas-dev#35721) Co-authored-by: Joris Van den Bossche <[email protected]>
…renders (pandas-dev#35722) Co-authored-by: attack68 <[email protected]>
…ons (pandas-dev#35738) Co-authored-by: Richard Shadrach <[email protected]>
…st version (pandas-dev#35761) Co-authored-by: Ali McMaster <[email protected]>
Hello @TAJD! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-09-13 11:52:47 UTC |
Not sure how to fix the test failures - have these been seen before? |
…eric_data (pandas-dev#36188) Co-authored-by: jbrockmendel <[email protected]>
…ntinel_none for 32bit (pandas-dev#36200) Co-authored-by: Simon Hawkins <[email protected]>
pandas-dev#36134) (pandas-dev#36199) Co-authored-by: Harsh Sharma <[email protected]>
… groupby.rolling (pandas-dev#36203) Co-authored-by: patrick <[email protected]>
…pandas-dev#36213) Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
…#36217) Co-authored-by: Simon Hawkins <[email protected]>
…e does not preserve dataframe index name (pandas-dev#36221) Co-authored-by: Irv Lustig <[email protected]>
Co-authored-by: Simon Hawkins <[email protected]>
The failure looks related:
This test ends up calling
|
My working hypothesis is that the worker failure could be due to the size of the array created to test if the error is being raised. Using tracemalloc it can be seen that the memory allocated during cartesian_product with X as the above value or using the test case for error bounds is around 4 petabytes. This sort of thing breaks the code when the memory is actually created. What I'm wondering is on how to limit the size of the array which is created or whether there is a way to pick a test input which triggers the error without breaking the machine being used. |
@TAJD you need to merge master |
Thanks @jreback I should have read the documentation! |
black pandas
git diff upstream/master -u -- "*.py" | flake8 --diff
Added a test to trigger the reported error using code from the issue. An if statement was included to return a more helpful error message - borrowing the solution from the issue.