Skip to content

REGR: MultiIndex Indexing #35353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2020
Merged

REGR: MultiIndex Indexing #35353

merged 3 commits into from
Jul 21, 2020

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins
Copy link
Member Author

I'll add tests if nothing breaks. I'm not keen on special casing the base Index method, but overriding _reindex_non_unique maybe overkill. maybe better to revert part of #33691

@simonjayhawkins simonjayhawkins added Bug Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Regression Functionality that used to work in a prior pandas version labels Jul 20, 2020
@simonjayhawkins
Copy link
Member Author

simonjayhawkins commented Jul 20, 2020 •
edited
Loading

test failures unrelated, see #34850 so marking as ready for review. whatsnew needed for regression in rc?

@simonjayhawkins simonjayhawkins marked this pull request as ready for review July 20, 2020 18:06
@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Jul 20, 2020
@TomAugspurger
Copy link
Contributor

Thanks, LGTM.

whatsnew needed for regression in rc?

I don't think so.

@jreback
Copy link
Contributor

jreback commented Jul 20, 2020

mpl issue breaking the docs?

@simonjayhawkins
Copy link
Member Author

rebased and green. since this is for 1.1, I suppose this could be merged even without a firm decision on the branch strategy.

@TomAugspurger
Copy link
Contributor

Yep, thanks.

@TomAugspurger TomAugspurger merged commit 3e88e17 into pandas-dev:master Jul 21, 2020
@simonjayhawkins simonjayhawkins deleted the mi-regression branch July 21, 2020 11:30
ebardie pushed a commit to ebardie/pandas that referenced this pull request Jul 21, 2020
@simonjayhawkins @eBardieCt
REGR: MultiIndex Indexing (pandas-dev#35353)
5124efd 
* REGR: MultiIndex Indexing

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves MultiIndex Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

BUG: multiindex slice 1.1.0rc0
3 participants
@simonjayhawkins @TomAugspurger @jreback