CI: pin isort version #35136
Merged
CI: pin isort version #35136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps some other changes in 5.0 that will take more time. I was just about to push a commit pinning to <5 for now. Thanks @AlexKirko. |
AlexKirko
changed the title
jorisvandenbossche
approved these changes
Jul 6, 2020
|
Thanks @TomAugspurger for the quick fix! |
|
Docs are being fixed in #35139. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffScope
Remove the--recursivekeyword fromcode_checks.sh, so that the newest version of isort can run without errors (it does recursive sorting by default).Pin the version instead, because version 5 has changed the way isort sorts imports. Needs more work to switch safely.