Fix - BUG: AssertionError when slicing MultiIndex and setting value o… #34973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
luckydenis
commented
Jun 24, 2020
luckydenis
commented
- closes BUG: AssertionError when slicing MultiIndex and setting value of pandas.Series #34870
- tests added / passed (1 / 1)
dsaxton
reviewed
Jun 24, 2020
pandas/core/indexes/base.py
Outdated
| @@ -4947,9 +4949,9 @@ def slice_indexer(self, start=None, end=None, step=None, kind=None): | |||
| start_slice, end_slice = self.slice_locs(start, end, step=step, kind=kind) | |||
|
|
|||
| # return a slice | |||
| if not is_scalar(start_slice): | |||
| if not is_scalar(Fraction(start_slice)): | |||
There was a problem hiding this comment.
Can you explain why we're trying to turn this into a fraction? I think this may only be working by accident since TypeErrors are getting caught upstream.
pandas/tests/indexing/test_loc.py
Outdated
| test.loc[('baz', 'one'):('foo', 'two')] = 4 | ||
| correct[('baz', 'one'):('foo', 'two')] = 4 | ||
|
|
||
| assert correct.equals(test) |
There was a problem hiding this comment.
Can you explicitly construct the expected output (i.e., rather than setting with another form of indexing) and then use assert_series_equal to test this (naming the two Series result and expected)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.