Skip to content

DOC: Fix validation issues with Index.is_ docstring #34882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2020
Merged

DOC: Fix validation issues with Index.is_ docstring #34882

merged 2 commits into from
Jun 20, 2020

Conversation

cvanweelden
Copy link
Contributor

  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Fix validation issues with the Index.is_ docstring and add Index.identical to see also section. Trying to finish what was started in #32357

@MarcoGorelli MarcoGorelli self-requested a review June 20, 2020 09:37
MarcoGorelli
MarcoGorelli suggested changes Jun 20, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this up!

@MarcoGorelli MarcoGorelli self-requested a review June 20, 2020 09:52
MarcoGorelli
MarcoGorelli approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Pretty sure the CI errors are unrelated. You may be asked to merge the upstream/master branch once the CI is fixed so that this is green before it's merged

@cvanweelden
Copy link
Contributor Author

Yeah, the CI issues are from master branch. The issue that the original PR was hanging on is in "CI / Web and docs" which passed now.

jorisvandenbossche
jorisvandenbossche approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@jorisvandenbossche jorisvandenbossche merged commit fe6e56d into pandas-dev:master Jun 20, 2020
@jorisvandenbossche jorisvandenbossche added this to the 1.1 milestone Jun 20, 2020
wesbarnett pushed a commit to wesbarnett/pandas that referenced this pull request Jun 20, 2020
@cvanweelden @wesbarnett
DOC: Fix validation issues with Index.is_ docstring (pandas-dev#34882)
93e75d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@cvanweelden @jorisvandenbossche @MarcoGorelli @charlesdong1991