don't need len around shape #34337
Closed
don't need len around shape #34337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @SilasK - could you add a test to show how this fixes the issue? |
jreback
reviewed
May 25, 2020
| @@ -4789,7 +4789,7 @@ def _maybe_convert_for_string_atom( | |||
|
|
|||
| # we cannot serialize this data, so report an exception on a column | |||
| # by column basis | |||
| for i in range(len(block.shape[0])): | |||
| for i in range(block.shape[0]): | |||
There was a problem hiding this comment.
can you show what the block.shape is in the test suite now (pick a couple of example tests).
|
@SilasK this needs a test where this breaks / why you are changing |
|
@SilasK do you have time to add a test? |
|
Sorry, not for the moment. And It would be a test that test that the error message is produced correctly, how do I do that?
|
|
@SilasK Thanks for the PR. closing as stale. LMK if you want to continue and I'll reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Fix #34274
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff