Skip to content

TST: Remove some old xfails #33680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions pandas/tests/arrays/sparse/test_arithmetics.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ def _assert(self, a, b):

def _check_numeric_ops(self, a, b, a_dense, b_dense, mix, op):
with np.errstate(invalid="ignore", divide="ignore"):
if op in [operator.floordiv, ops.rfloordiv]:
# FIXME: GH#13843
if self._base == pd.Series and a.dtype.subtype == np.dtype("int64"):
pytest.xfail("Not defined/working. See GH#13843")

if mix:
result = op(a, b_dense).to_dense()
else:
Expand Down
21 changes: 0 additions & 21 deletions pandas/tests/groupby/test_function.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
NaT,
Series,
Timestamp,
_is_numpy_dev,
date_range,
isna,
)
Expand Down Expand Up @@ -698,11 +697,6 @@ def test_numpy_compat(func):
getattr(g, func)(foo=1)


@pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummin(numpy_dtypes_for_minmax):
dtype = numpy_dtypes_for_minmax[0]
min_val = numpy_dtypes_for_minmax[1]
Expand Down Expand Up @@ -751,11 +745,6 @@ def test_cummin(numpy_dtypes_for_minmax):
tm.assert_series_equal(result, expected)


@pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummin_all_nan_column():
base_df = pd.DataFrame({"A": [1, 1, 1, 1, 2, 2, 2, 2], "B": [np.nan] * 8})

Expand All @@ -766,11 +755,6 @@ def test_cummin_all_nan_column():
tm.assert_frame_equal(expected, result)


@pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummax(numpy_dtypes_for_minmax):
dtype = numpy_dtypes_for_minmax[0]
max_val = numpy_dtypes_for_minmax[2]
Expand Down Expand Up @@ -819,11 +803,6 @@ def test_cummax(numpy_dtypes_for_minmax):
tm.assert_series_equal(result, expected)


@pytest.mark.xfail(
_is_numpy_dev,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
)
def test_cummax_all_nan_column():
base_df = pd.DataFrame({"A": [1, 1, 1, 1, 2, 2, 2, 2], "B": [np.nan] * 8})

Expand Down
3 changes: 0 additions & 3 deletions pandas/tests/groupby/transform/test_transform.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
MultiIndex,
Series,
Timestamp,
_is_numpy_dev,
concat,
date_range,
)
Expand Down Expand Up @@ -330,8 +329,6 @@ def test_transform_transformation_func(transformation_func):
if transformation_func in ["pad", "backfill", "tshift", "cumcount"]:
# These transformation functions are not yet covered in this test
pytest.xfail("See GH 31269")
elif _is_numpy_dev and transformation_func in ["cummin"]:
pytest.xfail("https://github.com/pandas-dev/pandas/issues/31992")
elif transformation_func == "fillna":
test_op = lambda x: x.transform("fillna", value=0)
mock_op = lambda x: x.fillna(value=0)
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/io/test_pickle.py
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ def test_pickle_path_localpath():
tm.assert_frame_equal(df, result)


@pytest.mark.xfail(reason="GitHub issue #31310", strict=False)
def test_legacy_sparse_warning(datapath):
"""

Expand Down
7 changes: 0 additions & 7 deletions pandas/tests/scalar/period/test_period.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
from datetime import date, datetime, timedelta
from distutils.version import StrictVersion

import dateutil
import numpy as np
import pytest
import pytz
Expand Down Expand Up @@ -1437,11 +1435,6 @@ def test_period_immutable():
per.freq = 2 * freq


@pytest.mark.xfail(
StrictVersion(dateutil.__version__.split(".dev")[0]) < StrictVersion("2.7.0"),
reason="Bug in dateutil < 2.7.0 when parsing old dates: Period('0001-01-07', 'D')",
strict=False,
)
def test_small_year_parsing():
per1 = Period("0001-01-07", "D")
assert per1.year == 1
Expand Down
1 change: 1 addition & 0 deletions pandas/tests/scalar/timedelta/test_arithmetic.py
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,7 @@ def test_td_div_numeric_scalar(self):
np.float64("NaN"),
marks=pytest.mark.xfail(
_is_numpy_dev,
raises=RuntimeWarning,
reason="https://github.com/pandas-dev/pandas/issues/31992",
strict=False,
),
Expand Down