BUG: Fix behavior of isocalendar with timezones #33551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgmarino
commented
Apr 14, 2020
mgmarino
commented
- If timezone is not UTC, then convert to UTC
- This bug was found while deprecating 'week' and 'weekofyear'
- If timezone is not UTC, then convert to UTC
mgmarino
force-pushed
the
fix-bug-in-isocalendar
branch
from
5601797 to
eccc904
Compare
mroeschke
reviewed
Apr 14, 2020
|
|
||
|
|
||
| def test_isocalendar_returns_correct_values_close_to_new_year_with_tz(): | ||
| # GH 6538: Check that DatetimeIndex and its TimeStamp elements |
There was a problem hiding this comment.
You can just use the GH number of this PR (# GH 33551 )
mroeschke
reviewed
Apr 14, 2020
|
thanks |
CloseChoice
pushed a commit
to CloseChoice/pandas
that referenced
this pull request
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.