Skip to content

Conversation

ShaharNaveh
Copy link
Contributor


I can also add examples that would cover, ````TimedeltaPropertiesandPeriodProperties```, but I think that would be over verbose, wdyt?

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MomIsBestFriend lgtm pending green

@simonjayhawkins simonjayhawkins added this to the 1.1 milestone Apr 3, 2020
@simonjayhawkins
Copy link
Member

I can also add examples that would cover, ````TimedeltaPropertiesandPeriodProperties```, but I think that would be over verbose, wdyt?

agreed.

Examples
--------
>>> datetime_series = pd.Series(
... pd.date_range("2000-01-01", periods=3, freq="m")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example can be fine, but this example produced a datetimes spaced by month end instead of minute. Was this the intention?

Copy link
Contributor Author

@ShaharNaveh ShaharNaveh Apr 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mroeschke Thank you, fixed.

@jreback jreback merged commit 82999c8 into pandas-dev:master Apr 6, 2020
@jreback
Copy link
Contributor

jreback commented Apr 6, 2020

thanks @MomIsBestFriend

@ShaharNaveh ShaharNaveh deleted the DOC-FieldAccessor-core-arrays-datetimes branch April 7, 2020 10:48
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants