Skip to content

CLN: Split pandas/tests/base/test_ops.py #32744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2020
Merged

CLN: Split pandas/tests/base/test_ops.py #32744

merged 2 commits into from
Mar 17, 2020

Conversation

SaturnFromTitan
Copy link
Contributor

As suggested by @jreback in this PR comment

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@SaturnFromTitan SaturnFromTitan added Clean Testing pandas testing functions or related to the test suite and removed Clean Testing pandas testing functions or related to the test suite labels Mar 16, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Mar 17, 2020
@jreback jreback added this to the 1.1 milestone Mar 17, 2020
@jreback
Copy link
Contributor

jreback commented Mar 17, 2020

great, i think we merged something, can you rebase.

cc @jbrockmendel who has an outstanding PR that overlaps a bit here (well inserting some new things)

@jbrockmendel
Copy link
Member

I dont think any of my PRs have a conflict here; if they do I'll rebase when the time comes

@SaturnFromTitan SaturnFromTitan force-pushed the split-tests-base-test_ops branch from c9669df to 2c2ddc6 Compare March 17, 2020 06:02
@SaturnFromTitan
Copy link
Contributor Author

@jreback @jbrockmendel Conflicts resolved and CI green

@jreback jreback merged commit 81149fb into pandas-dev:master Mar 17, 2020
@jreback
Copy link
Contributor

jreback commented Mar 17, 2020

thanks @SaturnFromTitan

SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@SaturnFromTitan @SeeminSyed
CLN: Split pandas/tests/base/test_ops.py (pandas-dev#32744)
ca93eed
jbrockmendel pushed a commit to jbrockmendel/pandas that referenced this pull request Mar 23, 2020
@SaturnFromTitan @jbrockmendel
CLN: Split pandas/tests/base/test_ops.py (pandas-dev#32744)
10ce047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SaturnFromTitan @jreback @jbrockmendel