-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: Fix HDFStore empty keys on native HDF5 file by adding keyword include #32723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 18 commits into
pandas-dev:master
from
roberthdevries:fix-29916-by-adding-keyword-include
Jun 14, 2020
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
22808a0
HDFStore: Fix empty result of keys() method on non-pandas hdf5 file
roberthdevries e023d11
Flake8 fixes
roberthdevries efe00f6
black reformatter
roberthdevries df9c536
Add whatsnew entry
roberthdevries f7c9c32
Correct the order of the keywords in the docstring
roberthdevries 4f1ccd6
Minor cleanups
roberthdevries 64bb567
Make test code for the non-pandas case a bit more explicit
roberthdevries 5dbaa4c
Changed new keyword parameter 'kind' to 'include'
roberthdevries 69bd5b6
Add test to check the error path for an illegal `include` keyword par…
roberthdevries c39fc76
Fix pylint error
roberthdevries b590f53
Remove Optional from include parameter
roberthdevries 91c81af
Add versionadded tag
roberthdevries fab73a7
Added .get to test
roberthdevries f1ce709
Fix versionadded tag 3rd try
roberthdevries 4ef7b87
Fix docstring empty lines
roberthdevries 8969623
Linting: Fix space at the start at the string
roberthdevries 51d632d
More idiomatic python
roberthdevries 0f5dd68
Remove "Otherwise fail with a ValueError" as requested
roberthdevries File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.