BUG: Rolling groupby should not maintain the by column in the resulting DataFrame#32332

Closed

MarcoGorelli wants to merge 41 commits intopandas-dev:masterfrom

MarcoGorelli:rolling-groupby

Commits on Mar 5, 2020

make sure exclusions are applied before the groupby object reaches rolling
Marco Gorelli
committed
pass object with exclusions earlier on

MarcoGorelli
authored and
Marco Gorelli
committed
revert accident

MarcoGorelli
authored and
Marco Gorelli
committed
check for side effects in obj

MarcoGorelli
authored and
Marco Gorelli
committed
wip

MarcoGorelli
authored and
Marco Gorelli
committed
Wip

MarcoGorelli
authored and
Marco Gorelli
committed
change _selected_obj according to self.mutated

MarcoGorelli
authored and
Marco Gorelli
committed
sanitize

MarcoGorelli
authored and
Marco Gorelli
committed
update old tests

MarcoGorelli
authored and
Marco Gorelli
committed
fix old docstring

MarcoGorelli
authored and
Marco Gorelli
committed
finish correcting old docstring

MarcoGorelli
authored and
Marco Gorelli
committed
use getattr

MarcoGorelli
authored and
Marco Gorelli
committed
old fix
Marco Gorelli
committed
simpler fix
Marco Gorelli
committed
try making Window's own _shallow_copy
Marco Gorelli
committed
more wip
Marco Gorelli
committed
typeerror!
Marco Gorelli
committed
add some types, comment tests
Marco Gorelli
committed
fix typing
Marco Gorelli
committed
better fix
Marco Gorelli
committed
correct return annotation
Marco Gorelli
committed
simplify code
Marco Gorelli
committed
fix upstream, remove try except
Marco Gorelli
committed
document change as api-breaking
Marco Gorelli
committed

Commits on Mar 19, 2020

Merge remote-tracking branch 'upstream/master' into rolling-groupby
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed

Commits on Mar 21, 2020

deal with multiindexed columns case
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
use elif in _obj_with_exclusions, add test for column multiindex, display dataframe in whatsnew entry separately from before vs after
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
simplify unique_column_names
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
rewrite using get_level_values
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
revert 'or' which was accidentally changed to 'and'
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
only patch _apply, cov and corr
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
reinstate change to _obj_with_exclusions
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed

Commits on Mar 22, 2020

exclude 'by' column in Rolling.count
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
don't modify _selected_obj - instead, patch obj before we reach apply
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
slight simplification to _shallow_copy
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed
comment on patch in corr and cov
Marco Gorelli/DI /SRUK/Engineer/Samsung Electronics
committed