Skip to content

CLN: D300 Use """triple double quotes""" #31888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

simonjayhawkins
Copy link
Member

No description provided.

@WillAyd
Copy link
Member

WillAyd commented Feb 11, 2020

looks good; is this a code that should be added to CI?

@simonjayhawkins
Copy link
Member Author

looks good; is this a code that should be added to CI?

these are pydocstyle error codes, http://www.pydocstyle.org/en/5.0.2/error_codes.html. pydocstyle has support for numpy convention checks and a flake8 plugin. It is current;y used by matplotlib and there could possibly be collaboration between numpy and pydocstyle, see numpy/numpydoc#213 (comment), for the static elements.

there is overlap and differences between validate_docstrings and pydocstyle and so both tools could complement each other. The flake8 plugin is handy for ide highlighting. the pydocstyle cli could be handy for ci.

at these stage just looking to formalise the clean-ups in #31162, #31462 and others. then we can look to lock-down.

@WillAyd WillAyd merged commit 4a1fbad into pandas-dev:master Feb 11, 2020
@WillAyd
Copy link
Member

WillAyd commented Feb 11, 2020

Cool sounds good

@simonjayhawkins simonjayhawkins deleted the D300-Use-triple-double-quotes branch February 11, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants