Skip to content

add messages to tests #31852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 19, 2020
Merged

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Feb 10, 2020

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raisadz !

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good generally a few minor things

@simonjayhawkins simonjayhawkins added the Testing pandas testing functions or related to the test suite label Feb 11, 2020
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor cleanups left otherwise lgtm

@raisadz raisadz force-pushed the test_messages_extension branch from c24ba57 to f54510d Compare February 18, 2020 09:16
@raisadz raisadz requested a review from WillAyd February 18, 2020 09:59
@jbrockmendel jbrockmendel merged commit 30bb0f0 into pandas-dev:master Feb 19, 2020
@jbrockmendel
Copy link
Member

Thanks @raisadz

roberthdevries pushed a commit to roberthdevries/pandas that referenced this pull request Mar 2, 2020
* add messages to tests

* changes to test_boolean.py

* split error messages

* change to test_isin.py

* changes to test_boolean.py and test_indexing.py

* revert changes to test_diff.py

* cleanups to the code

* changes to test_boolean.py and test_replace.py

* change error message in test_to_dict.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants