REF: pass str_rep through arithmetic ops more consistently #31297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @jbrockmendel! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-02-22 15:50:32 UTC |
gfyoung
added
Refactor
gfyoung
reviewed
Jan 25, 2020
jreback
requested changes
Jan 25, 2020
| @@ -748,7 +748,7 @@ def f(self, other, axis=default_axis, level=None): | |||
| return _combine_series_frame(self, other, op, axis=axis) | |||
| else: | |||
| # in this case we always have `np.ndim(other) == 0` | |||
There was a problem hiding this comment.
see my comment on your other PR. I would rather not do this as another arg, better is to create a NamedTuple that holds both and pass that around
There was a problem hiding this comment.
another alternative would be to make the getting of str_rep a dict lookup in expressions
|
closing to clear the queue |
|
re-opening, this is a step on the path to doing frame-with-frame ops blockwise |
jbrockmendel
added
expressions
jreback
approved these changes
Feb 22, 2020
|
lgtm. rebase ping on green. |
|
rebased+green |
|
thanks |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't get all of the places where we fail to pass str_rep, still working out a couple of places where passing it breaks tests.