REF: avoid calling engine for EA values #31258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
ExtensionArray
jreback
requested changes
Jan 23, 2020
| @@ -2892,14 +2892,17 @@ def _get_value(self, index, col, takeable: bool = False): | |||
| engine = self.index._engine | |||
|
|
|||
| try: | |||
| return engine.get_value(series._values, index) | |||
| if isinstance(series._values, np.ndarray): | |||
There was a problem hiding this comment.
i understand why you are doing this (does it affect perf btw?)
but is not a great long term pattern. can you instead factor this to a function (which you can also use in Series)?
There was a problem hiding this comment.
long-term this is going to be made unnecessary when Series._values is changed to match Index._values. At that point libindex.get_value_at and IndexEngine.get_value will become entirely unnecessary
jreback
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.