Skip to content

BUG: DTA/TDA/PA add/sub object-dtype #30594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 1, 2020

Conversation

jbrockmendel
Copy link
Member

Bonus: we get to get rid of is_offsetlike

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green. is this a bug fix? e.g. is there an issue

@jreback jreback added Period Period data type Timedelta Timedelta data type Datetime Datetime data dtype labels Jan 1, 2020
@jreback jreback added this to the 1.0 milestone Jan 1, 2020
@jbrockmendel
Copy link
Member Author

is this a bug fix? e.g. is there an issue

There is no associated issue. I stumbled on this when implementing block-wise arithmetic for the non-scalar cases.

@jbrockmendel
Copy link
Member Author

ping

@jreback jreback merged commit f3642d2 into pandas-dev:master Jan 1, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2020

k thanks.

@jbrockmendel jbrockmendel deleted the bug-dtlike-obj branch January 1, 2020 03:47
hweecat pushed a commit to hweecat/pandas that referenced this pull request Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Period Period data type Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants