Skip to content

Conversation

ShaharNaveh
Copy link
Contributor

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel jbrockmendel added Docs Code Style Code style, linting, code_checks labels Dec 9, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Note relevant black issue on Cython support; maybe something soon:

psf/black#359

@WillAyd WillAyd added this to the 1.0 milestone Dec 9, 2019
@WillAyd WillAyd merged commit ad0539b into pandas-dev:master Dec 10, 2019
@WillAyd
Copy link
Member

WillAyd commented Dec 10, 2019

Thanks @MomIsBestFriend

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh ShaharNaveh deleted the CLN-_libs-#3 branch December 20, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants