Skip to content

STY: 'open()' and 'close()' to 'with' context manager #29851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 27, 2019
Merged

STY: 'open()' and 'close()' to 'with' context manager #29851

merged 3 commits into from
Nov 27, 2019

Conversation

ShaharNaveh
Copy link
Member

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@ShaharNaveh ShaharNaveh changed the title STY: 'open()' and 'close()' to 'with' context manager REF: 'open()' and 'close()' to 'with' context manager Nov 26, 2019
@ShaharNaveh ShaharNaveh changed the title REF: 'open()' and 'close()' to 'with' context manager STY: 'open()' and 'close()' to 'with' context manager Nov 26, 2019
WillAyd
WillAyd approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. this is just vendored code but no problem making this change.

Can you merge master to fix CI?

@WillAyd WillAyd added the Code Style Code style, linting, code_checks label Nov 27, 2019
@WillAyd WillAyd added this to the 1.0 milestone Nov 27, 2019
@jreback
Copy link
Contributor

jreback commented Nov 27, 2019

thanks @MomIsBestFriend ideally you could push this change upstream to pyperclip itself as well.

@jreback jreback merged commit d26b18c into pandas-dev:master Nov 27, 2019
@ShaharNaveh ShaharNaveh deleted the CLN-io-clipborad branch November 27, 2019 15:09
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: 'open()' and 'close()' to 'with' context manager (pandas-dev#29851)
55c8ae0
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@ShaharNaveh @proost
STY: 'open()' and 'close()' to 'with' context manager (pandas-dev#29851)
66c5483
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShaharNaveh @jreback @WillAyd