Skip to content

Update nullable integer docs with None instead of np.nan #29619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

lucassa3
Copy link
Contributor

Update nullable integer docs with None instead of np.nan

Update nullable integer docs with None instead of np.nan
@TomAugspurger
Copy link
Contributor

This seems fine.

I'm not sure whether avoiding the original problem (a trip through a float dtype ndarray) is worth fixing or not, when the user provides np.nan (which is a float).

@TomAugspurger TomAugspurger added this to the 1.0 milestone Nov 14, 2019
@jreback jreback merged commit 0511754 into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks @lucassa3

@lucassa3
Copy link
Contributor Author

@jreback no problem. Glad I could help ^^

Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
…29619)

Update nullable integer docs with None instead of np.nan
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…29619)

Update nullable integer docs with None instead of np.nan
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
…29619)

Update nullable integer docs with None instead of np.nan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullable integer documentation examples are incorrect
3 participants