ensure consistent structure for groupby on index and column #29357
Conversation
simonjayhawkins
added
the
Testing
| ).set_index("a"), | ||
| ], | ||
| ) | ||
| @pytest.mark.parametrize( |
There was a problem hiding this comment.
can you use the fixture all_numeric_reductions (you can simply replace method with this)
There was a problem hiding this comment.
I've just checked, if I remove the second pytest parametrisation and use all_numeric_reductions (from pandas.conftest) as the second parameter the test will throw an error of AttributeError: 'DataFrameGroupBy' object has no attribute 'kurt'.
There was a problem hiding this comment.
I think can also use reduction_func from the groupby contest. Might need to consolidate those fixtures at a later point
There was a problem hiding this comment.
In that case tests fail for ngroup and nth reductions: AssertionError: assert FrozenList(['a']) == FrozenList(['a', 'c']) and TypeError: nth() missing 1 required positional argument: 'n' respectively.
There was a problem hiding this comment.
So the test in #29124 is already doing this with all of the groupby funcs though with a different intent (duplicate column labels). Maybe after that gets merged we come back to this and see if this makes sense to fit into that test as well via some sort of parametrization; not sure it's worth doing as a one-off
|
Thanks for the PR! But I think this was already covered in #29124 |
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff