Skip to content

CLN: remove merge-pr script, clean Exception in tm, doc #28442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2019

Conversation

jbrockmendel
Copy link
Member

I count 131 of these ATM, some of which we'll end up marking as intentionally non-specific.

title = title.encode("raw_unicode_escape")
except Exception:
pass

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pandas-dev/pandas-core : Out of curiosity, how many people actually use this nowadays?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never used it, happy to get rid of it if nobody does.

@gfyoung gfyoung added Clean Error Reporting Incorrect or improved errors from pandas labels Sep 15, 2019
@jorisvandenbossche
Copy link
Member

I never use it anymore, and I think we fully switched to using github's button to merge PRs. But maybe some people still use it to fetch PR's branchs and push back there?

@jreback
Copy link
Contributor

jreback commented Sep 15, 2019

yeah i think we can blow away the merge script

@jbrockmendel
Copy link
Member Author

Updated to remove merge-pr.py

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - minor comments

@@ -50,6 +50,7 @@ def test_dask(df):
assert ddf.compute() is not None


@pytest.mark.filterwarnings("ignore:Panel class is removed")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this not causing CI failures before? Thought we failed on warnings like this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is showing up locally

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be needed with latest xarray I suppose

@WillAyd WillAyd added this to the 1.0 milestone Sep 16, 2019
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jorisvandenbossche jorisvandenbossche changed the title CLN: Exception in tm, scripts, doc CLN: remove merge-pr script, clean Exception in tm, doc Sep 16, 2019
@jorisvandenbossche jorisvandenbossche merged commit 4e43629 into pandas-dev:master Sep 16, 2019
@jorisvandenbossche
Copy link
Member

Thanks!

@jbrockmendel jbrockmendel deleted the faster16 branch September 16, 2019 20:56
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants