Easy warning fixups for mypy #27402
Merged
Easy warning fixups for mypy #27402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jul 15, 2019
| lengths = [] | ||
|
|
||
| meta_vals = defaultdict(list) # type: DefaultDict | ||
| if not isinstance(sep, str): |
There was a problem hiding this comment.
I suppose this would break code if someone tried to provide a non-str sep but that's not documented and unclear why someone would try that anyway
There was a problem hiding this comment.
could it be a remnant of py2 compatibility? for public methods should we allow bytes in all places where a string is expected?
There was a problem hiding this comment.
Not sure but on closer inspection doesn't seem to work in general case anyway:
>>> json_normalize({ 'foo' : { 'bar' : 0 } }, sep=b'.')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/williamayd/clones/pandas/pandas/io/json/_normalize.py", line 266, in json_normalize
data = nested_to_record(data, sep=sep, max_level=max_level)
File "/Users/williamayd/clones/pandas/pandas/io/json/_normalize.py", line 106, in nested_to_record
new_d.update(nested_to_record(v, newkey, sep, level + 1, max_level))
File "/Users/williamayd/clones/pandas/pandas/io/json/_normalize.py", line 91, in nested_to_record
newkey = prefix + sep + k
TypeError: can only concatenate str (not "bytes") to strSo just seems like a mistake
simonjayhawkins
approved these changes
Jul 15, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #27396 @simonjayhawkins some of these were just easy cleanups.
Didn't look through all but some of the others are more complicated and probably require in depth review